rokucommunity / vscode-brightscript-language

A Visual Studio Code extension for Roku's BrightScript language
MIT License
111 stars 40 forks source link

Can't build apps after 2.1.20 #244

Closed luis-soares-sky closed 4 years ago

luis-soares-sky commented 4 years ago

Using VS Code 1.45.1, Node 12.8.1, in macOS 10.14.6 (Mojave).

Given the following launch configuration...

        {
            "type": "brightscript",
            "request": "launch",
            "consoleOutput": "normal",
            "internalConsoleOptions": "openOnSessionStart",
            "preLaunchTask": "gulp vscPreLaunchEnv",
            "name": "Debug (.env)",
            "envFile": "${workspaceFolder}/.env",
            "host": "${env:ROKU_DEV_TARGET}",
            "password": "${env:ROKU_DEV_PASSWORD}",
            "retainStagingFolder": false,
            "stopOnEntry": false,
            "files": [
                "*",
                "*.*",
                "**/*.*"
            ],
            "rootDir": "${workspaceFolder}/build",
            "sourceDirs": [
                "${workspaceFolder}/"
            ]
        },

In 2.1.19 this config works, and builds run successfully.

In 2.1.20 I get an error saying "outDir is required" message.

image

If I add "outDir": "${workspaceFolder}/out" to it, then I'll get an error saying "connect ECONNREFUSED 127.0.0.1:8060".

image

TwitchBronBron commented 4 years ago

What's strange about this is, all that changed between 2.1.19 and 2.1.20 was some updates to the language server. The only part of brighterscript that is being used by the launch workflow is bsconfig.json if it exists.

Do you have a bsconfig.json file in your project?

luis-soares-sky commented 4 years ago

What's strange about this is, all that changed between 2.1.19 and 2.1.20 was some updates to the language server. The only part of brighterscript that is being used by the launch workflow is bsconfig.json if it exists.

Do you have a bsconfig.json file in your project?

I don't have a bsconfig.json file. The project is in the root directory, we use gulp to process and export some files into the "build/" folder, but outside of that, everything else is just standard BrightScript projects.

I've tried it on multiple projects (simple and complex) and got the same results. Reverting to 2.1.19 solves the issues.

luis-soares-sky commented 4 years ago

image

Not sure if it is relevant, but it seems that in 2.1.20, the "Output" view doesn't show any of the extension logs that used to appear (Log, Debug, Language Server...)

jean-guyrivard commented 4 years ago

Same issue, and reverting to 2.1.19 fixes the issue. In my case the outDir, once fixed I get an error with invalid URI with http://${promptForHost}/keypress/home which probably explains the connection refused from the OP.

chrisdp commented 4 years ago

So we found the issue. @TwitchBronBron Is planing to get a new build out tonight we the fix.

Thanks.

TwitchBronBron commented 4 years ago

Fixed in v2.1.21

luis-soares-sky commented 4 years ago

Can confirm the fix. Thank you very much!

koganiz commented 3 years ago

The issue is back in 2.22.1

TwitchBronBron commented 3 years ago

This has been resovled in v2.22.2 and was caused by a missing prod dependency in roku-deploy