search

rokucommunity / vscode-brightscript-language

A Visual Studio Code extension for Roku's BrightScript language
MIT License
110 stars 41 forks source link

Add support for VS Code for the Web #332

Closed luis-soares-sky closed 2 years ago

luis-soares-sky commented 2 years ago

Github "recently" created github.dev (press . while viewing a project/PR) which uses the web version of VS Code. However, the BrightScript Language extension isn't supported at all.

image

So it would be great if the extension was (at least partially) supported by the web version of VSC, so that anyone could use github.dev to review PRs that contain .bs files.

TwitchBronBron commented 2 years ago

I'm definitely open to supporting this! There is a LOT of nodejs-specific code in the extension, so I'm not sure what all it would take to get the extension fully operational, but even if we could just get syntax highlighting working, that would be a great start.

TwitchBronBron commented 2 years ago

FYI, I'm reading the docs about this. I'll try to play around with a basic implementation in the next week or so. Colorization should be very simple.

TwitchBronBron commented 2 years ago

@luis-soares-sky I just submitted #333 which adds the minimal required info to get the extension to launch in the browser. Almost none of the features will work right now, as we need to refactor the build process to bundle for web.

TwitchBronBron commented 2 years ago

@luis-soares-sky did you have a chance to test it out yet? Are there additional features you'd like to see sooner rather than later?

luis-soares-sky commented 2 years ago

I believe the immediate requirement from our team was mainly syntax highlighting, as that's mostly what we use the web version for. Some of us have tested it and it seems to be running smoothly!