search

rokucommunity / vscode-brightscript-language

A Visual Studio Code extension for Roku's BrightScript language
MIT License
110 stars 41 forks source link

Add all launch.json options into user settings under `brightscript.debug` #399

Closed TwitchBronBron closed 2 years ago

TwitchBronBron commented 2 years ago

The debugger currently supports adding any launch.json setting to user settings under brightscript.debug. However, almost none of those options are documented, so they show up as "unknown value".

  1. Copy (duplicate, don't move) all of the launch.json options into user settings. The naming convention should be brightscript.debug.<name launch config value> .

This will result in a lot of duplication, but will provide a much nicer user experience. If you're feeling creative, you could write a nodejs (typescript) script to auto-sync all the launch.json settings into the package.json user settings instead of copying them by hand.

philandersonaccedo commented 2 years ago

Picking up this ticket and working on it ...

Have got the basic logic working for the automated script ... just have to apply it now and get all of the settings synchronized between the two places

philanderson888 commented 2 years ago

Code is now complete and submitted for pull request

philanderson888 commented 2 years ago

https://github.com/rokucommunity/vscode-brightscript-language/pull/438

philanderson888 commented 2 years ago

Now I have the code functioning correctly there is one final thing - I remember I have to now add the linting tests, which are not currently running ...

philanderson888 commented 2 years ago

OK modified file to add in fixes for ESLinting errors highlighted

TwitchBronBron commented 2 years ago

Fixed by #438