search

rokucommunity / vscode-brightscript-language

A Visual Studio Code extension for Roku's BrightScript language
MIT License
110 stars 41 forks source link

Should give a warning if deployment fails #69

Closed georgejecook closed 5 years ago

georgejecook commented 5 years ago

Many of us change roku accounts frequently. When this happens, we might forget to enable debug mode, or the box might crash and not accept more deployments.

In any case, it'd be great to have an error/warning if the deployment is unsuccessful.

TwitchBronBron commented 5 years ago

What type of presentation do you think should should show for this? My top choice right now is one of those notifications at the bottom right of the screen. Like this one (but with error or warning status)

image

georgejecook commented 5 years ago

That’d make sense - it’d be consistent with other extensions I use.

On January 15, 2019 at 6:50:30 AM, Bronley Plumb (notifications@github.com) wrote:

What type of presentation do you think should should show for this? My top choice right now is one of those notifications at the bottom right of the screen. Like this one (but with error or warning status)

[image: image] https://user-images.githubusercontent.com/2544493/51178845-d2f35e00-1891-11e9-974b-729ded05775f.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TwitchBronBron/vscode-brightscript-language/issues/69#issuecomment-454366079, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKIURrE5xh8u9pomSjpeR9Wik-kPu4xks5vDcCEgaJpZM4aAuBs .

TwitchBronBron commented 5 years ago

I found a few places where the debug failure errors were not being bubbled up to the top, so I fixed those in this branch. I tested out a few other debuggers, and they all use the standard vscode debugger failure path, which is to call this.sendErrorResponse. That shows an alert box in the center of the screen. I'd be open to discussing alternatives, but in general I would like to stick to using the vscode standards wherever possible. Thoughts?

image

georgejecook commented 5 years ago

Frikking awesome. Thanks so much. The missed failures are really irritating and were seemingly random.

On Thu, Jan 17, 2019, 6:53 AM Bronley Plumb <notifications@github.com wrote:

I found a few places where the debug failure errors were not being bubbled up to the top, so I fixed those in this branch https://github.com/TwitchBronBron/vscode-brightscript-language/tree/feature/better-failure-presentation. I tested out a few other debuggers, and they all use the standard vscode debugger failure path, which is to call this.sendErrorResponse. That shows an alert box in the center of the screen. I'd be open to discussing alternatives, but in general I would like to stick to using the vscode standards wherever possible. Thoughts?

[image: image] https://user-images.githubusercontent.com/2544493/51316975-4c22ba80-1a24-11e9-9a7a-3ddc0c4d65a6.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TwitchBronBron/vscode-brightscript-language/issues/69#issuecomment-455145746, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKIUWR5lCK6472YQx-QamC1CmQC4qI8ks5vEGQ2gaJpZM4aAuBs .