rokudev / samples

Collection of sample channels for side-loading on your Roku device
MIT License
460 stars 290 forks source link

Only use variant for ad tracking, return HLS master manifest for video playback #17

Open KasperGam opened 4 years ago

KasperGam commented 4 years ago

When using simple adapter for VOD playback, the returned "playURL" was a single variant of the master manifest, and thus would lose captions information and the ability to switch variants based on network speed.

The variant is still needed to track the ad, but the video node should still get the master playlist for HLS to work correctly.

I also bumped the version number to indicate a change.

@LockChristian @smathairoku is there a reason the library doesn't have indentation? It is very hard to read without any formatting. Could I open a PR with the file formatted (using the VS-code extension formatter)?