search

rokudev / samples

Collection of sample channels for side-loading on your Roku device
MIT License
460 stars 290 forks source link

Fix macos ping flags closes #28 #29

Open GabLeRoux opened 3 years ago

GabLeRoux commented 3 years ago

See #28 I confirmed with an example that this does indeed fix the problem on macOS.

pfontain commented 2 years ago

Also verified that this fixes the issue in macOS.

hunter4466 commented 1 year ago

I've been looking for a solution in mac, this PR actually resolves my problem, you guys should resolve conflicts and merge this PR ASAP

fahrnbach commented 3 months ago

Just confirming that this small (3 Line) fix approved above does work.

For anyone else wondering, you can modify the template makefile found in the official "Hello World" tutorial https://developer.roku.com/en-gb/docs/developer-program/getting-started/hello-world.md

Add the lines found above that @pfontain approved.

For reference the approval can be found here: https://github.com/rokudev/samples/pull/29/files/3139c3fa6a43f137720b075c8818cc4c2d2a7f91