search

rokups / ImNodes

Node graph implementation for Dear ImGui. Used in https://github.com/rokups/rbfx
MIT License
656 stars 57 forks source link

correcting issue #19 and Style -> style_ #20

Closed sonoro1234 closed 3 years ago

sonoro1234 commented 3 years ago

Solves issue #19 and also redo style_ in previous PR for cimgui compatibility.

rokups commented 3 years ago

style_

Seems to me this should be fixed on cimgui side. I can understand avoiding use of special syntax as that is tricky to parse, but requiring upstream project to adopt unusual coding style in some places sounds bit much.

sonoro1234 commented 3 years ago

It is just that Style is used by imnodes (https://github.com/Nelarius/imnodes) that being also C wrapped makes a collision with another Style definition. I dont mind how it is called. (Could be CanvasStyle?) Otherwise you could merge but changing style_ to Style and I could wrap every struct name with its parent struct and namespace names.

rokups commented 3 years ago

I see. CanvasStyle works, yes :+1:

sonoro1234 commented 3 years ago

Should I do a new PR?

rokups commented 3 years ago

No need. You can amend commit in this one, or just push, and i will squash on merge. Whatever is most convenient for you :)

sonoro1234 commented 3 years ago

done!!