search

rokwire / core-building-block

Building block which handles core functions for the Rokwire platform - users, accounts, profiles, organizations, authentication and authorization.
Apache License 2.0
3 stars 2 forks source link

[BUG] Device ID not nullable #672

Closed roberlander2 closed 1 year ago

roberlander2 commented 1 year ago

Describe the bug On login requests and login session responses, API document validation will require that the device_id is not null. It is unlikely but possible that the client cannot get its device ID, so in these cases we do not want to prevent login (or prevent getting login sessions when device_id is null).

To Reproduce Steps to reproduce the behavior:

  1. Try to login using any client
  2. If deviceId is null, login will fail (deviceId is unlikely to be null, so this is not easily reproducible)

Expected behavior Allow login and getting login sessions when device_id is null.