993 feature dropdown menu on edit page.

bingzhang commented 1 year ago

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[x] When possible

Type of changes

Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

[x] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[x] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

sandeep-ps commented 1 year ago

Hi, @bingzhang, Is this PR ready to be reviewed? If so, could you please add the CHANGELOG entry and add reviewers? Thanks.

bingzhang commented 1 year ago

Hi, @bingzhang, Is this PR ready to be reviewed? If so, could you please add the CHANGELOG entry and add reviewers? Thanks.

@sandeep-ps it is not done yet. Some dropdown menu item cannot be selected. and save causes some issues. I am going to change it to draft.

minump commented 1 year ago

There is a orange underline in the dropdown menu Screen Shot 2023-02-01 at 9 51 01 AM

The highlight colour (option 2) is working.

Theres a bug when the dropdown menu is activated and the page is scrolled up. The menu is displayed over the header.

Screen Shot 2023-02-01 at 9 50 40 AM

bingzhang commented 1 year ago

There is a orange underline in the dropdown menu

The highlight colour (option 2) is working.

Theres a bug when the dropdown menu is activated and the page is scrolled up. The menu is displayed over the header.

@minump fix the orange line. And the scroll to the top will be addressed in another issue. Please rewview.

minump commented 1 year ago

@bingzhang The dropdown menu format has been reversed to the default formatting. It was working before. I think somethings have been changed. Screen Shot 2023-02-09 at 12 27 10 PM

bingzhang commented 1 year ago

@bingzhang The dropdown menu format has been reversed to the default formatting. It was working before. I think somethings have been changed.

@minump I tried again and also on the incognito, I do not have this problem.

bingzhang commented 1 year ago

@sandeep-ps can you please take a look at this pr?

minump commented 1 year ago

In edit page, the drop-down menu's look good. The extra orange line is disabled. The dropdown follows the design. However, in create page, it is the default drop down. Edit page : Screen Shot 2023-02-14 at 9 50 56 AM

Create page : Screen Shot 2023-02-14 at 9 49 53 AM

Also some buttons and the checkbox is in the default styles. Maybe that PR has not yet been merged. So that can be treated as separate issue, if not yet resolved.

bingzhang commented 1 year ago

In edit page, the drop-down menu's look good. The extra orange line is disabled. The dropdown follows the design. However, in create page, it is the default drop down. Edit page :

Create page :

Also some buttons and the checkbox is in the default styles. Maybe that PR has not yet been merged. So that can be treated as separate issue, if not yet resolved.

@minump Just want to let you know, there is a issue to add dropdown menu on create page. there will be another pr.

minump commented 1 year ago

In edit page, the drop-down menu's look good. The extra orange line is disabled. The dropdown follows the design. However, in create page, it is the default drop down. Edit page : Create page : Also some buttons and the checkbox is in the default styles. Maybe that PR has not yet been merged. So that can be treated as separate issue, if not yet resolved.

@minump Just want to let you know, there is a issue to add dropdown menu on create page. there will be another pr.

Sounds good. Would be nice to have some issue description to that effect as well. In the issue, nor in the PR, it is mentioned this will only consider edit pages.

bingzhang commented 1 year ago

In edit page, the drop-down menu's look good. The extra orange line is disabled. The dropdown follows the design. However, in create page, it is the default drop down. Edit page : Create page : Also some buttons and the checkbox is in the default styles. Maybe that PR has not yet been merged. So that can be treated as separate issue, if not yet resolved.

@minump Just want to let you know, there is a issue to add dropdown menu on create page. there will be another pr.

Sounds good. Would be nice to have some issue description to that effect as well. In the issue, nor in the PR, it is mentioned this will only consider edit pages.

This issue is very old. the previous plan to implement all dropdown menus. but in this sprint, we created issues to customize each page.

sandeep-ps commented 1 year ago

Thanks for your feedback, Minu.

@bingzhang, Thanks for updating the PR description. I have updated the issue description.

I gave some thoughts about the drop-down menu overlapping with the navigation bar. Its position may need to be fixed at the top where the select appears, as we do on the event listing page (please see screenshot below). If you can fix that in the current PR, it's good. If not, please create a follow-up issue for that. Thanks.

sandeep-ps commented 1 year ago

Also, when you get a chance, could you please reply to the open conversations so I can restart revisiting each of them? Thanks.

bingzhang commented 1 year ago

Thanks for your feedback, Minu.

@bingzhang, Thanks for updating the PR description. I have updated the issue description.

I gave some thoughts about the drop-down menu overlapping with the navigation bar. Its position may need to be fixed at the top where the select appears, as we do on the event listing page (please see screenshot below). If you can fix that in the current PR, it's good. If not, please create a follow-up issue for that. Thanks.

that is the default built-in dropdown menu. We do not have code to fix or prevent the customized dropdown menu go to nav bar. I think it will be another pr.

bingzhang commented 1 year ago

Also, when you get a chance, could you please reply to the open conversations so I can restart revisiting each of them? Thanks.

I already resolved them.

sandeep-ps commented 1 year ago

that is the default built-in dropdown menu. We do not have code to fix or prevent the customized dropdown menu go to nav bar. I think it will be another pr.

Okay. Sounds good. Please create an issue for that. Thanks.

bingzhang commented 1 year ago

I tested this with changes to drop down items in edit mode for both pending and published events. I'm approving this PR. Please create a follow up issue related to dropdown overflow. Thanks.

sure I am going to create it.

rokwire / events-manager