rokwire / events-manager

Events Manager is the administrative interface to events in the Rokwire Platform. Through this web application, users can manage existing events coming from calendars and/or create and manage user events.
Apache License 2.0
1 stars 4 forks source link

disable button style updates #1052

Closed bingzhang closed 1 year ago

bingzhang commented 1 year ago

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

Type of changes

Please select a relevant option:

Checklist:

Please select all applicable options:


minump commented 1 year ago

I do not see a text-shadow property that is mentioned in zeplin design for the Disabled button (text-shadow: 0 1px 3px rgba(0, 0, 0, 0.5);)

But to my eyes it looks similar and looks good to me without text-shadow. Screen Shot 2023-02-09 at 12 32 02 PM

sandeep-ps commented 1 year ago

Yes, I agree that the text properties need to match what's in the design. Thanks.

bingzhang commented 1 year ago

duplicated. closed.