Exclude events from WebTools with certain categories

bingzhang commented 1 year ago

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[x] When possible

Type of changes

Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

sandeep-ps commented 1 year ago

Hi, @bingzhang, I see that there is an existing code where we check whether the incoming category is known. I think it may be better to modify that with a continue statement to ignore unknown/excluded categories. That way, we do not have to update included and excluded categories during future changes. Also, please see my comment on this issue: https://github.com/rokwire/events-manager/issues/1085#issuecomment-1574200638. Thanks.

bingzhang commented 1 year ago

Hi, @bingzhang, I see that there is an existing code where we check whether the incoming category is known. I think it may be better to modify that with a continue statement to ignore unknown/excluded categories. That way, we do not have to update included and excluded categories during future changes. Also, please see my comment on this issue: #1085 (comment). Thanks.

update the code. please check again.

bingzhang commented 1 year ago

@sandeep-ps please review again. thanks.

minump commented 1 year ago

Wouldn't constants.py eventTypeMap need to be changed? I see "Community/Service" and "Ceremony/Service" still in line https://github.com/rokwire/events-manager/blob/ef2a95c21d0fe8de64b0f75cb27f6088980a33b3/utilities/constants.py#L51 Or maybe I didnt understand the issue correctly?

sandeep-ps commented 1 year ago

Wouldn't constants.py eventTypeMap need to be changed? I see "Community/Service" and "Ceremony/Service" still in line

https://github.com/rokwire/events-manager/blob/ef2a95c21d0fe8de64b0f75cb27f6088980a33b3/utilities/constants.py#L51

Or maybe I didnt understand the issue correctly?

I will jump in here. It's removed in a different PR that deals with the mapping. https://github.com/rokwire/events-manager/pull/1088/files. In the issue, I mentioned that the new mapping might just be needed, but we saw that some logic update is needed for the categories to be excluded.

rokwire / events-manager