1102 bug subcategory functionality

minump commented 1 year ago

Description

Changed category name from "Athletics" to "Big 10 Athletics" and added "Recreation , Health & Fitness" category as well to subcategory-menu. Changed in add-new-event page and event-edit page. Removed unwanted and undefined functions like "enableScroll", "disableScroll" and removed unwanted console logs.

This PR is built on https://github.com/rokwire/events-manager/pull/1103 . Please review https://github.com/rokwire/events-manager/pull/1103 first.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[ ] When possible

Type of changes

Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[ ] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

bingzhang commented 1 year ago

@minump I cannot add you as a reviewer.

minump commented 1 year ago

@minump I cannot add you as a reviewer.

np. change it from "draft PR" to "ready to review". I'll test and leave comment of approval once done.

minump commented 1 year ago

Tested in local. Able to select "Big 10 athletics" and "Recreation Health & Fitness" categories and subcategories. Tried creating and editing the event. Works fine.

The changelog is missing the release section heading of 3.6.0. Other than that it looks fine.

Approving.

sandeep-ps commented 1 year ago

Merging this PR. I will continue testing Events BB while the Events Manager release is being reviewed.

sandeep-ps commented 1 year ago

We need to handle categories and subcategories better in the Events Manager. For example, use the mapping from the Events BB and not hard code it here. Adding this comment to create a GitHub issue.

minump commented 1 year ago

Merging this PR. I will continue testing Events BB while the Events Manager release is being reviewed.

Before merging, i or @bingzhang can fix the changelog release header?

minump commented 1 year ago

and... merged... nvm..

minump commented 1 year ago

and... merged... nvm..

Checked the release branch. I see the issue being reflected in the changelog. So all good.

rokwire / events-manager