rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 21 forks source link

[BUG] Campus Guide Highlights should be auto added to their Favorites widget #3032

Open joegrohens opened 1 year ago

joegrohens commented 1 year ago

Describe the bug When a Campus Guide article is promoted as a "Highlight", it should be listed automatically in two places:

  1. Browse > Campus Guide > Campus Guide Highlights
  2. Favorites > Campus Guide Highlights.

At this writing there are four items in Browse > Campus Guide > Campus Guide Highlights:

browse highlights list copy

None of these items appears in Favorites > Campus Guide Highlights:

highlights widget copy

What should be done

  1. The Favorites Widget for Campus Guide Highlights should be populated automatically with ALL items that have the appropriate promotion interval, user role, and i-card value for the particular user. (In other words, if an item appears in Browse > Campus Guide > Campus Guide Highlights, it should also appear in the favorites widget.

  2. The wording in the screen of the Favorites widget for Campus Guide Highlights should be changed. When there are no items to display in the favorites widget for Campus Guide Highlights, it should display the following text: Promoted content from Campus Guide will appear here automatically.

mihail-varbanov commented 1 year ago

This should be resolved in version 4.3.41. Please note that the guide entry should be marked as favorete by default (content_type_favorite =true).

joegrohens commented 1 year ago

The Campus Guide Highlights do not appear in the favorites widget in 4.3.43 dev.

campus guide highlights copy

joegrohens commented 1 year ago

The Campus Guide Highlights also do not appear in the favorites widget in 4.3.46 dev.

campusguidehighlights copy

joegrohens commented 1 year ago

This issue is still unresolved in v4.3.47 dev

campus guide highlights

mihail-varbanov commented 1 year ago

Hi @joegrohens,

I hope you understand that Campus Guide Highlights widget in Favorites panel displays guide article that are:

  1. Promotion, that is currently active;
  2. Marked as favorite.

Currently I see just one active promoted item labeled "Illinois App Service Status Webpage". However it is not marked to be set as favorite by default. I mentioned earlier above "Please note that the guide entry should be marked as favorite by default (content_type_favorite =true).".

I just checked the situation in the Admin app and noticed that it does not enable the Favorite checkbox for promoted items. Dobromir will fix this today and it will get available in the admin app version 4.1.19. Once you mark "Illinois App Service Status Webpage" as Favorite in the admin app you should see it in the Campus Guide Highlights widget in the Favorites panel.

joegrohens commented 1 year ago

@mihail-varbanov

Thank you for your answers.

  1. I added CampusWell Advice Videos to "Highlights". Now there are two test cases.

CampusWell did appear in Browse > Campus Guide > Campus Guide Highlights It did not appear in the favorites widget for highlights.

  1. I enabled the "Favorite" switch for Campus Guide Highlights. It did not make appear in the faves widget at first. But after about 1 hour, it did.

  2. There is no Favorite switch for Campus Guide content-types, so, I don't see a way of marking "Illinois App Service Status" as a Favorite from within the Admin App. Are you saying that the Favorite switch for Campus Guide content-types will be added in Admin 4.1.19? Or only that the promoted items will become automatically favorited?

I am using Admin App build 4.1.12 - the stand-alone app, not the web app.

joegrohens commented 1 year ago

PS - Should I re-assign this to you for you to see my new comment? I decided to re-assign you and Mark to make sure you see it.

mihail-varbanov commented 1 year ago

Hi @joegrohens,

It is a good practice to assign the issue to us when you expect some action or even answer. GIT notifies us for all comments in the issues that we are involved in but this is often dropped in the sea of notifications. Also, please keep in mind that we are often busy with development of new features and cannot respond in time to all GIT comments.

1. It is normal for the update to take some time. In general, in the dev environment, sending the application to the background and then activating it back after 2 minutes should make the update visible. In the production environment this time interval is 3 hours.

2. The only way to make an item favorite by default, i.e. without the user doing this explicitly, is to turn on the Favorite checkbox in the Admin app. I just checked the admin app and noticed that the Favorite checkbox is visible for promoted items but the taps on it are ignored. I will let @dobromirdobrev know about this to fix it.

mihail-varbanov commented 1 year ago

Update: we just updated the admin app so the fix for Favorite checkbox should get available in the next build for version 4.1.20

joegrohens commented 1 year ago

Thank you, @mihail-varbanov

mihail-varbanov commented 1 year ago

You are welcome, @joegrohens.

I forgot to mention that the quickest way to acknowledge guide content updates in the client app is to restart it by first killing the app and then launching it again.