search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
21 stars 19 forks source link

[BUG] Favorites icon slightly different color #3317

Open JosephShepin opened 1 year ago

JosephShepin commented 1 year ago

Notice that the star above the "favorites" text on the bottom nav bar is a lighter gray than all the other icons that are not currently selected.

Screenshot_20230603-233307

Android 13, Pixel 7

TodorBachvarov commented 10 months ago

All icons used in the Nav Bar are with the same colour: MediumGray. "star-outline-gray": {"src": "images/icon-star-gray-frame-thin.png", "type": "flutter.asset", "color": "mediumGray", "size": 18}, "campus-tools-outline-gray": {"src": "images/tab-browse.png", "type": "flutter.asset", "color": "mediumGray", "size": 18, "todo": "size"}, "location-outline-gray": {"src": "images/tab-navigate.png", "type": "flutter.asset", "color": "mediumGray", "size": 18, "todo": "size"}, etc.

My assumption is that the favorites icon is slightly thinner that the rest icons. In order to fix this I'll need new icon resource with the appropriate size. @pmarkhennessy, could you redirect this issue to the designers team for assistance.

TodorBachvarov commented 10 months ago

@vburgett we will need new icon resource.

vburgett commented 2 weeks ago

This is fixed in version 5.1.34.