search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 21 forks source link

[BUG] At a privacy level 3, can't access Sign In/Sign Out under Profile #4103

Open vburgett opened 5 months ago

vburgett commented 5 months ago

When viewing the app at privacy level 3, a user can only see "Who Are You" under Profile and NOT "SIgn In/Sign Out."

I expect to see "SIgn In/Sign Out" under Profile at all privacy levels

Dev 6.0.4

https://github.com/rokwire/illinois-app/assets/1044905/b95d9b63-3dd0-4d8c-8085-463dc1bd93be

mihail-varbanov commented 5 months ago

@vburgett, this behavior is by design. Authentication feature is available only to privacy levels 4 or 5.

mihail-varbanov commented 4 months ago

Hi @vburgett,

I consider that the current behavior most probably does not bring a good user experience. It is inherited from the past where the user UI content was dynamic and depended on miscellaneous factors like privacy level, profile role (student, alumni, etc.), logged status and so on. This content generally varies and the user is never sure when a given feature is available.

In my opinion it is much better to keep the UI content permanent, and if a given feature is not available and the user attempts to use it to display an appropriate message. In the current case, we should always keep the Sign In section available and visible, and if the user tries to sign in to explain why he or she cannot do this - due to the privacy level that he/she has set. This should not be done just for a single or few locations in the application. We need to make a complete scan through the entire app content, find all UI components whose availability depends on different settings, and decide how to proceed in each single case. This is a good task for some next major release, but not for the 6.0.

CC @pmarkhennessy

vburgett commented 1 month ago

Reopening this for the winter release.

mihail-varbanov commented 4 days ago

This must be resolved in version 6.1.17.

vburgett commented 4 days ago

Thank you, @mihail-varbanov. It seems to be working well in 6.1.17. Can we adjust the pop-up message when a user tries to sign in with a privacy level 1, 2, or 3 to read:

To sign in, set your privacy level to 4 or 5 under Settings.

Please underline the text "set your privacy level" and make it a link to Settings > My App Privacy Settings.

Screenshot_20241112-154901

mihail-varbanov commented 3 days ago

Hi @vburgett, the message is updated in 6.1.18.