search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 21 forks source link

[BUG] Illinois Assistant FAQ's - hyperlinks and external link icons are missing #4113

Open Priyaravi8 opened 4 months ago

Priyaravi8 commented 4 months ago

Describe the bug Hyperlinks and external link icons are missing in the Illinois Assistant FAQ's page

To Reproduce Steps to reproduce the behavior:

  1. Install the app
  2. Navigate to Illinois Assistant FAQ's page

Actual result In Illinois Assistant FAQ's, links are not working as hyperlinks and external link icons are missing

Expected behavior Add hyperlinks and external link icons to all the links in Illinois Assistant FAQ's,

Smartphone (please complete the following information):

dobromirdobrev commented 4 months ago

Hi @Priyaravi8 ,

These are the resources that we have for implementing the new Assistant UI:

  1. There are no hyperlinks in these resources. I assume that you mean the underlined portion of text in the FAQs. Example: Screenshot 2024-06-25 at 11 07 42

However, neither in the PDF, nor in the Zeplin UI is described where these "possible" hyperlinks should point to. So, please, provide us with detail information which are the hyperlinks and where should they lead to (url ).

  1. There are no external link icons in the provided resources. So, if you want us to add such icons, please provide detailed information where they should be placed (after hyperlink or somewhere else?).

If we don't have this information, we won't be able to accomplish this task (I wouldn't refer this issue as BUG :) ).

Thanks.

vburgett commented 4 months ago

@dobromirdobrev please see the links and instructions for external icons in this doc: https://docs.google.com/document/d/12xocxzNg5vFF_pElzvYksSHgg_2JMs4MnyrQLAIu8CM/edit?usp=sharing

dobromirdobrev commented 4 months ago

Thank you, @vburgett ! This is exactly what we needed. The desired changes are made in the Illinois app. You can verify them when you have a chance. New app build is not needed, so you can test with the latest version on dev. Thanks. cc @Priyaravi8

vburgett commented 4 months ago

All looks accurate to me. Thank you, @dobromirdobrev.