[BUG] Wellness and Academics Links missing from Sections

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.

https://app.illinois.edu/

Apache License 2.0

23 stars 21 forks source link

[BUG] Wellness and Academics Links missing from Sections #4143

Closed vburgett closed 4 months ago

vburgett commented 5 months ago

Below are edits to the Academic and Wellness lists under Home > Sections. (In 5.1, these items are only listed under the Academic and Wellness panel dropdown menus which are not part of 6.0 with the merging of Browse and Favorites.)

Please add to Sections > Academics:

myIllini (no star, under My Courses)—can the chevron right icon be replaced with the external window icon?

Please add to Sections > Wellness:

Change "Rings" to "Daily Rings" and move to the top of the Wellness list above "Daily Tip"
Add link to the article "Healthy Illini Podcast" above "Illinois Health Screener" (no star)
Add link to the article "I'm Struggling" below "Illinois Health Screener" (no star)

mihail-varbanov commented 4 months ago

@vburgett, I believe these all had been implemented in version 6.0.11.

vburgett commented 4 months ago

Thank you, @mihail-varbanov. Sections > Academics > myIllini needs to open in a browser outside of the app to avoid sign in issues on this external website.

mihail-varbanov commented 4 months ago

@vburgett, I am sorry for this, I did not test it well last Friday. This is fixed in version 6.0.12.

vburgett commented 4 months ago

Confirming as fixed in 6.0.12. Thank you, @mihail-varbanov.

Priyaravi8 commented 4 months ago

@mihail-varbanov - Please check this - As per Vanessa's note - Add link to the article "I'm Struggling" below "Illinois Health Screener" (no star). But in Version 6.0.17, "I'm Struggling" is displayed above "Illinois Health Screener"

vburgett commented 4 months ago

Thanks, @Priyaravi8. I believe it is correctly alphabetized in your screenshot. @bstandard please confirm.

bstandard commented 4 months ago

@Priyaravi8 is correct. Alphabetization is letter-by-letter and apostrophes are ignored. Order is: Healthy Illini Podcast Illinois Health Screener I'm Struggling

mihail-varbanov commented 4 months ago

We used а standard lexicographic sort in Sections and that's why "I'm Struggling" appeared before "Illinois Health Screener". Now some custom and non-standard sort rules are requested that I tried to implement. Let's just note that we are ignoring not only apostrophes but generally all symbols that are not alphanumeric or space (r"[^\w\s]+"), e.g. dash, dot, comma, quotation marks, brackets and so on. Also, the string comparison is case insensitive as it was before. This has been implemented in version 6.0.18.

vburgett commented 4 months ago

@mihail-varbanov In 6.0.19 I am still seeing the incorrect order under Sections > Wellness. This is the correct placement of "I'm Struggling":

Healthy Illini Podcast Illinois Health Screener I'm Struggling

mihail-varbanov commented 4 months ago

@vburgett, sorry about that. I remember that I verified the updated sort order after my fix but now I saw it was not what needs to be again. I have no idea how this happened.

Anyway, I fixed it again and now it should be OK, available in version 6.0.20.

vburgett commented 4 months ago

Confirming as updated. Thank you!