search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 21 forks source link

[BUG] Wallet should not pre-load history dining transactions #4341

Open kpecknold opened 2 months ago

kpecknold commented 2 months ago

JP approves this fix for the release going out next week.

When the wallet is opened, the app retrieves all of the dining balance data as well as past transactions/history. The query that is retrieving the past dining transactions is putting a huge burden on the POS system. It brought the dining POS server down on Sunday. Clint made a temp fix by "breaking" it. To fix this problem, I think we should:

1) Split into 2 API calls - Do not pull any past transaction history unless the user taps "View History"
2) Remove the custom date range 3) Default to using a two week past date range = today's date, back 2 weeks. So, start date = 2 weeks ago, end date = today's date 4) Move the "View History" button above the "Classic Meal History" and "Dining Dollars History" sections. A similar change is needed on the Illini Cash display

Vanessa, if you have specific design instruction to add, please feel free to do so here.

@vburgett @clint156

mihail-varbanov commented 2 months ago

Resolved in version 6.0.42.

vburgett commented 2 months ago

@kpecknold the update looks good to me, and it also works fine for me, but I do not have a meal plan.

clint156 commented 2 months ago

This looks good to me as well. The app is not automatically loading my Illini Cash transaction history and the load history seems to be working. I don't have any transactions in the last two weeks to show and am getting the correct message. I have enabled Illini Cash transaction history on the Housing API end point, so someone with transaction history in the last two weeks should be able to see something.