search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 20 forks source link

Dining Plan Balance Not Refreshing[BUG] #698

Open clint156 opened 3 years ago

clint156 commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

  1. go to browse
  2. Select meal plan
  3. Verify the meal plan name and meal balance remaining
  4. go back to the browse menu
  5. outside of the app, do something to change the balance remaining on the existing meal plan
  6. Select meal plan, the balance remaining remains the same

Expected behavior In the testing I did, I gave myself a meal plan and viewed balances. 0 came up as the meals remaining value, which is initially expected since Heartland requires that we process an adjustment for the correct balance to come up. After performing the adjustment in Heartland and reloading the meal plan screen, I should now see the full number of meals remaining. () is still being displayed.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

mdryankov commented 3 years ago

@clint156, could you please confirm that the GET https://web.housing.illinois.edu/MobileAppWS/api/ICEligible/{uin}/{fname}/{lname} is passed successfully with http response code 200 for a such user? If this request fail for any reason or give negative response, then the balance api won't be invoked at all? Those two apis are invoked in many scenarios like phone start, enter foreground, login etc so...

Please note I'm unable to reproduce this issue in case the described api gives positive response and the user is being eligible for illini cash

CC @pmarkhennessy

clint156 commented 3 years ago

Verified. Passing it my account, which I was using in testing yesterday: {"IlliniCashEligible":true,"AccountStatus":""}

It would refresh the meal plan name if that changed between visits to the meal plan details, just not the meals remaining balance. Do you have a way to change your balances between loads?

Clint Stearns Systems Development Architect, Student Affairs Technology

[Illinois-Wordmark-Horizontal-Full-Color-RGB_185px]

From: Mladen Dryankov @.> Sent: Friday, August 20, 2021 6:14 AM To: rokwire/illinois-app @.> Cc: Stearns, Clint L @.>; Mention @.> Subject: Re: [rokwire/illinois-app] Dining Plan Balance Not Refreshing[BUG] (#698)

@clint156https://urldefense.com/v3/__https:/github.com/clint156__;!!DZ3fjg!rsWMA0DRa7mCc21-CLuBH6ju6sEoyF9At8ECdqJH0ZjqRUILVBeyEjYXbBT8YuU_$, could you please confirm that the GET https://web.housing.illinois.edu/MobileAppWS/api/ICEligible/// is passed successfully with http response code 200 for a such user? If this request fail for any reason or give negative response, then the balance api won't be invoked at all? Those two apis are invoked in many scenarios like phone start, enter foreground, login etc so...

Please note I'm unable to reproduce this issue in case the described api gives positive response and the user is being eligible for illini cash

CC @pmarkhennessyhttps://urldefense.com/v3/__https:/github.com/pmarkhennessy__;!!DZ3fjg!rsWMA0DRa7mCc21-CLuBH6ju6sEoyF9At8ECdqJH0ZjqRUILVBeyEjYXbIwcZtgI$

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/rokwire/illinois-app/issues/698*issuecomment-902619815__;Iw!!DZ3fjg!rsWMA0DRa7mCc21-CLuBH6ju6sEoyF9At8ECdqJH0ZjqRUILVBeyEjYXbDbmbSAy$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ANWU2GEISXZL5RCTXZ6JSDDT5Y2FXANCNFSM5CPDCZMQ__;!!DZ3fjg!rsWMA0DRa7mCc21-CLuBH6ju6sEoyF9At8ECdqJH0ZjqRUILVBeyEjYXbIcuG9vv$. Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!DZ3fjg!rsWMA0DRa7mCc21-CLuBH6ju6sEoyF9At8ECdqJH0ZjqRUILVBeyEjYXbGhTWRBZ$ or Androidhttps://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!DZ3fjg!rsWMA0DRa7mCc21-CLuBH6ju6sEoyF9At8ECdqJH0ZjqRUILVBeyEjYXbMWCdzQC$.

mdryankov commented 3 years ago

@clint156 I think I found the issue. Please try with todays build and let us know.

CC @pmarkhennessy