rokwire / rokwire-building-blocks-api

Source code repository of the Rokwire App Config, Authentication, Events, Profile, and Logging Building Blocks, and Authentication Middleware Library.
Apache License 2.0
3 stars 4 forks source link

1084 card alignment in catalog home page #1096

Closed minump closed 1 year ago

minump commented 1 year ago

Description

Catalog home page card alignment done. Search bar style changed Bookshelf image style changed home page container width increased to fit more cards.

The bookshelf image is shorter than the home page container width. Hence the blank space on the left and right sides.

Screen Shot 2023-03-02 at 12 13 00 PM

Fixes #1084

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

Type of changes

Please select a relevant option:

Checklist:

Please select all applicable options:


minump commented 1 year ago

width : 975 px; margin-left:10px; Try this styling for card container in home page.

For the search textbox - have height of 40px (change from .form-control 48px height to 40px height); Or put a new line row after the search box div. Or add margin-top of 20px/18px for the myBtnContainer container class.

minump commented 1 year ago

Updated styling of catalog home page. Ready for review @sandeep-ps

sandeep-ps commented 1 year ago

Could you try without changing the height of the search box? (adding a blank line or adding a top margin for the main container) Since that's been standardized across all pages, that may be better.

minump commented 1 year ago

Could you try without changing the height of the search box? (adding a blank line or adding a top margin for the main container) Since that's been standardized across all pages, that may be better.

Updated. Removed height style css in search bar. Added space (margin-bottom ) before grid cards start.

minump commented 1 year ago

Merging to develop