1116 catalog texts and placeholders

minump commented 1 year ago

Description

Changed form field and placeholder wordings for contribute form.

Fixes #1116

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[x] Within a week
[ ] When possible

Type of changes

Please select a relevant option:

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

bingzhang commented 1 year ago

I did not check the text with google Docs. but the code looks good.

minump commented 1 year ago

some questions : "Select the Contribution Type and Add Details". --- this was "Select the Contribution Type" before. Since the label is for "Add Talent" and "Add Capability" buttons, do we need to change the label? The one lien description for "Add a Capability" label has been delete. Is the description for "Add a Talent" label is also deleted? As of now, in the google docs it is "Add a Talent (a User Interface Component that Provides a Specific Functionality)"

sandeep-ps commented 1 year ago

"Select the Contribution Type and Add Details". --- this was "Select the Contribution Type" before. Since the label is for "Add Talent" and "Add Capability" buttons, do we need to change the label? The one lien description for "Add a Capability" label has been delete. Is the description for "Add a Talent" label is also deleted? As of now, in the google docs it is "Add a Talent (a User Interface Component that Provides a Specific Functionality)"

I thought that when a user clicks that button, it's not just like selecting an option; a user needs to add more details. It's not very important, I think. I have updated the suggestions in the Google doc to fix the inconsistencies. Please see. Thanks for catching that.

minump commented 1 year ago

"Select the Contribution Type and Add Details". --- this was "Select the Contribution Type" before. Since the label is for "Add Talent" and "Add Capability" buttons, do we need to change the label? The one lien description for "Add a Capability" label has been delete. Is the description for "Add a Talent" label is also deleted? As of now, in the google docs it is "Add a Talent (a User Interface Component that Provides a Specific Functionality)"

I thought that when a user clicks that button, it's not just like selecting an option; a user needs to add more details. It's not very important, I think. I have updated the suggestions in the Google doc to fix the inconsistencies. Please see. Thanks for catching that.

Updated labels and placeholders. Ready for review.

minump commented 1 year ago

Merging to develop

rokwire / rokwire-building-blocks-api