rokwire / rokwire-building-blocks-api

Source code repository of the Rokwire App Config, Authentication, Events, Profile, and Logging Building Blocks, and Authentication Middleware Library.
Apache License 2.0
3 stars 4 forks source link

Update Event categories and subcategories list #1153

Closed bingzhang closed 1 year ago

bingzhang commented 1 year ago

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

Type of changes

Please select a relevant option:

Checklist:

Please select all applicable options:


sandeep-ps commented 1 year ago

Running the Mongodb import command will append new categories with previous categories.

@bingzhang, I think it's better to move this to db.py, and we need to replace the categories with the new categories. What do you think?

For the purpose of review, I will drop the local collection and add the new categories.

sandeep-ps commented 1 year ago

Please update the API specification file as the categories list is used in that too.

bingzhang commented 1 year ago

that is why I mentioned that in our technique meeting. I can work python code like what the current tag.json does.

sandeep-ps commented 1 year ago

Hi, @bingzhang, FYI, I'm updating this PR with README changes and potentially some minor code changes.