rokwire / rokwire-building-blocks-api

Source code repository of the Rokwire App Config, Authentication, Events, Profile, and Logging Building Blocks, and Authentication Middleware Library.
Apache License 2.0
3 stars 4 forks source link

Master to develop after 1.19.0 #1175

Closed minump closed 10 months ago

minump commented 11 months ago

Description

Release 1.19.0 branch to be merged to develop branch. Only EventsBB is released.

Fixes #1139

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

Type of changes

Please select a relevant option:

Checklist:

Please select all applicable options:


sandeep-ps commented 11 months ago

I think the detected secrets may need to be rerun and changes committed to fix the GitHub action error. This can be addressed on Tuesday.

sandeep-ps commented 10 months ago

Re-ran detect secrets scan using detect-secrets scan --baseline .secrets.baseline from the source root directory.

sandeep-ps commented 10 months ago

@bingzhang, Could you please take a quick look as well? From testing in the TEST instance, it looks like the event category changes were not part of the previous release. We missed catching this during the review process, too. After this is merged, I will create a new release for that.