1176 task release 1.20.0 for eventsBB

minump commented 10 months ago

Description

Release 1.20.0. Issue #1150 was not released in v 1.19.0. Added the event category update to v1.20.0. Only eventsBB changes are done. No other BB yaml file version is updated.

Fixes #1176

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[x] Within a week
[ ] When possible

Type of changes

Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[x] Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

minump commented 10 months ago

Tested in local. GET localhost:9000/events/categories responds with categories list and subcategories as expected.

[
    {
        "category": "Big 10 Athletics",
        "subcategories": [
            "Baseball",
            "Men's Basketball",
            "Men's Cross Country",
            "Football",
            "Men's Golf",
            "Men's Gymnastics",
            "Men's Tennis",
            "Men's Track Field",
            "Wrestling",
            "Women's Basketball",
            "Women's Cross Country",
            "Women's Golf",
            "Women's Gymnastics",
            "Women's Soccer",
            "Softball",
            "Swim Dive",
            "Women's Tennis",
            "Women's Track Field",
            "Volleyball"
        ]
    },
    {
        "category": "Campus Visits"
    },
    {
        "category": "Career Development"
    },
    {
        "category": "Ceremonies & Services"
    },
    {
        "category": "Club Athletics"
    },
    {
        "category": "Conferences & Workshops"
    },
    {
        "category": "Exhibits"
    },
    {
        "category": "Festivals & Celebrations"
    },
    {
        "category": "Film Screenings"
    },
    {
        "category": "Performances"
    },
    {
        "category": "Receptions & Open House Events"
    },
    {
        "category": "Recreation, Health & Fitness",
        "subcategories": [
            "Group Fitness",
            "Aquatics",
            "Ice Skating",
            "Personal Training",
            "Student Wellness",
            "Adventure Rec",
            "Summer Camp"
        ]
    },
    {
        "category": "Social & Informal Events"
    },
    {
        "category": "Speakers & Seminars"
    }
]

Ready for review.

sandeep-ps commented 10 months ago

Thanks, @minump.

@bingzhang, Could you please test the below request in the DEV instance?

http://api-dev.rokwire.illinois.edu/events?startDate.lte=2023-09-12T14:19:02&endDate.gte=2023-09-06T14:19:02&targetAudience=faculty&targetAudience=staff&category=Receptions%20&%20Open%20House%20Events

The primary thing to test is the categories part -> category=Receptions%20&%20Open%20House%20Events

I think there should be some events under this category, but 0 are being returned. Please test this locally by changing some event data (if needed). This and other similar requests with ampersand in category need to succeed to be backward compatible with Illinois app 4.0. Thanks.

bingzhang commented 10 months ago

Thanks, @minump.

@bingzhang, Could you please test the below request in the DEV instance?
http://api-dev.rokwire.illinois.edu/events?startDate.lte=2023-09-12T14:19:02&endDate.gte=2023-09-06T14:19:02&targetAudience=faculty&targetAudience=staff&category=Receptions%20&%20Open%20House%20Events
The primary thing to test is the categories part -> category=Receptions%20&%20Open%20House%20Events

I think there should be some events under this category, but 0 are being returned. Please test this locally by changing some event data (if needed). This and other similar requests with ampersand in category need to succeed to be backward compatible with Illinois app 4.0. Thanks.

this request has wrong url encoding. there is &. If you use the below one it works.

Receptions%20%26%20Open%20House%20Events

minump commented 10 months ago

Tested in local.

curl --location 'http://localhost:9000/events?category=Recreation%2C%20Health%20%26%20Fitness' \
--header 'ROKWIRE-API-KEY: key'

gives expected response.

minump commented 10 months ago

Merging PR. Will proceed with release deployment to dev and request for deployment to TEST and PROD.

rokwire / rokwire-building-blocks-api