search

roland-KA / OneRule.jl

Implementation of the 1-Rule data mining algorithm using the Julia programming language
MIT License
2 stars 0 forks source link

Add support for Julia 1.6 #3

Open ablaom opened 2 years ago

ablaom commented 2 years ago

Currently the julia compat is set at 1.7.

I think this would be helpful as Julia 1.6 is still the current Long Term Support release.

roland-KA commented 2 years ago

Done 👍 ... see: https://github.com/roland-KA/OneRule.jl/commit/0cdc333cbd733c8edb9e6058c8b5d28e86e67e48

Some additional thoughts about this point:

As I hadn't real dependencies on v1.7, this change required only minimal effort in my case. But I can imagine situations where going back to an older version of Julia could induce rewrite of some code, if the author of a model learns only at model registration about this requirement.

So I think, if it is a MLJ policy to support the LTS version of Julia, this should be mentioned somewhere in the docs (in "Adding Models for General Use or Quick-Start Guide to Adding Models) to make it clear in advance.