search

rolandhill / geoscience

QGIS plugin for geology and exploration. Drill hole desurvey/display and other utilities.
GNU General Public License v3.0
40 stars 11 forks source link

Clean Up DrillManager.py codebase #17

Open ALP2023 opened 10 months ago

ALP2023 commented 10 months ago

This issue is closed and now in review status - removed defunct code from DrillManager.py

Issue

Although the DrillManager.py document has detailed comments for functions and methods for the DrillManager Class, it contains a substantial amount of defunct commented-out code. This impacts the maintainability and readability of the codebase.

Why

Tasks

rolandhill commented 10 months ago

Actually, you might need to modify your PR and remove those .idea/ files first. My PR skills don't extend that far.

ALP2023 commented 10 months ago

Thanks Roland. Yeah I'd noted that too, need to go back have a look at my idea file. Been a rush job, my Web design crunched up a lot of time. I've done a few more but didn't do a pull request as I haven't tested it on QGIS. Thankfully this assessment is more about communication and gitbhub. OMG I'm not going to study full time whilst working concurrently again. Kids have banned me from doing so 🤣.

Really appreciate all your assistance. Maybe one day I'll be brave enough to write a plugin to automate some of my repetitive tasks on QGIS!

Cheers April

On Wed, 6 Dec 2023, 2:24 pm Roland Hill, @.***> wrote:

Actually, you might need to modify your PR and remove those .idea/ files first. My PR skills don't extend that far.

— Reply to this email directly, view it on GitHub https://github.com/rolandhill/geoscience/pull/17#issuecomment-1842168522, or unsubscribe https://github.com/notifications/unsubscribe-auth/A62CPLIG7Y4RCS4JCH2IP4DYIAFRVAVCNFSM6AAAAABADU5UESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGE3DQNJSGI . You are receiving this because you authored the thread.Message ID: @.***>