search

rolandleth / LTHPasscodeViewController

iOS 7 style Passcode Lock
MIT License
615 stars 143 forks source link

Layout comes aligned to top-left in iOS 8 #70

Closed dhiraj closed 10 years ago

dhiraj commented 10 years ago

in iOS 8, on both iPhone and iPad, the layout of the password input field (in simple mode) comes aligned to the top left. Apart from that the control seems to work fine - please have a look when you can.

Thanks!

rolandleth commented 10 years ago

I won't be really supporting the library after iOS 8, because the new LocalAuthentication framework provides kind of the same functionality: if TouchID is present and correct -> login, if TouchID is not present or failed 3 times -> show a password view.

mbjacks commented 10 years ago

The LocalAuthentication framework allows for interaction with TouchID only, it does not show a password view if the device doesn't have TouchID. Are you going to support iOS 8 or are you done after iOS 8 is released? Your passcode controller is great and still has a lot of use left!

rolandleth commented 10 years ago

Hmmm, I haven't tinkered with the framework, but I watched the WWDC video about it and here's the passage I was talking about (you can search for it on asciiwwdc, or watch the video itself, of course):

And, of course, on devices without Touch ID, or on devices without any Touch ID enrolled fingers, we have the standard passcode entry screen which is also shown in case that the Touch ID is disabled, or when user decided that he will use passcode instead of Touch ID on the previous screen.

mbjacks commented 10 years ago

Yeah I remember seeing that part as well. Unfortunately, the LAContext for the LocalAuthentication framework doesn't support the passcode entry screen yet. Hopefully they do end up supporting it. In the meantime, I have made some changes for your library to work for iOS 8, but it breaks previous version support. If I have some time to fix it for other versions I may submit a pull request later.

rolandleth commented 10 years ago

That's sad, but I too hope they add support, like they said at WWDC.

Thanks! Though I'd wait with accepting a PR till at least the GM of iOS 8, to be sure nothing else breaks later on.

MaxHasADHD commented 10 years ago

I don't think they are adding the lock screen to iOS 8 anymore. I looking into it and reported it, they have no said anything to me yet and others on the developer forums say that Apple has changed their mind. Apps like 1Password, or something with a login already like Facebook, Paypal and such can use the local authentication to ask for finger or you enter the account password instead of device passcode. They should have had an option for apps to have their own passcode system or use the iOS passcode screen but It doesn't seem like they will be having It anymore.

dhiraj commented 10 years ago

@mbjacks Could you please post your iOS 8 - only code for LTHPasscodeViewController? I'm not going to support iOS 7 when 8 comes out, and I need to have a look at the fixes you've made. Thanks!