rolandoislas / multi-hotbar

Multiple hotbars for Minecraft
http://minecraft.curseforge.com/projects/multi-hotbar
Other
13 stars 4 forks source link

Static Inventory #34

Closed calloatti closed 6 years ago

calloatti commented 6 years ago

MC 1.12.1 multihotbar-1.12.1-3.1-build-T75

When opening the furnace GUI the top and bottom row are switched when the curent item is at the top row.

Before:

image

Opening GUI, notice how rows switched:

image

After. The top and bottom row are switched. Now the pick is selected. This also happens randomly all the time, cannot find a pattern as to why rows switch.

image

rolandoislas commented 6 years ago

In reply to Bluesatin: In order to remain compatible with vanilla servers, when a hotbar is swapped, the contents of the active hotbar are put into the bottom row of the inventory and the contents that were there previously take the spot in the old row. The inventory gets jumbled as these swaps happen and there can not be a static order as the active hotbar is set to a specific row.

The custom inventory fixes this slightly by rendering the items in a static order, taking the scrambling into consideration. The latest alpha build does not use a custom inventory and reorders correctly for the player inventory screen, but fails with any other container.

Moving forward, I will be adding server-side handing when the mod is detected on a server (which will be always in the singleplayer integrated server). This will fix the jumbled inventory.

calloatti commented 6 years ago

Oh well, thank you for replying. This was not happening in the previous version (T71 I think).

I tried using the custom inventory, but it was emptying the Immersive Engineering crates in the inventory.

And yes, I am using it in single player.

calloatti commented 6 years ago

Your reply explained what I was seeing, and now I found the cause for the row swaps:

Here I have a portable grid currently selected on the top row:

image

When I right click to open the grid inventory, the rows get swapped, I understand why you do that, to keep compatibility with vanilla servers.

image

Now when I close the portable grid inventory, the rows remain swapped:

image

Couldn't you just keep track that you swapped the rows before showing any inventory GUI and swapping them back when the GUI is closed?

Another example with the wireless grid:

image

image

image