search

rolandschulz / PTP

Eclipse Parallel Tools Platform
http://www.eclipse.org/ptp/
6 stars 3 forks source link

Multiple Configuration Problems #35

Open eblen opened 13 years ago

eblen commented 13 years ago

There are multiple problems with the GUI configuration, mainly due to the difficulty of adapting the CDT extensions to work correctly with sync projects. Since these problems and their solutions are likely to be closely related, they are all placed in a single issue. Below are two problems. Others will follow:

1) Initial toolchain selection is ambiguous. Is it for local or remote? For now, it is for both, and the user may have to remember to change one of them later. A toolchain combo on the sync wizard page would help but doesn't eliminate the ambiguity. Is there a better way to present these options to the user?

2) The sync builder must be used in order for the system to work correctly. Although it is set as the default, users can change it. Even worse, if the user selects an alternate toolchain, the builder is changed to something else. So users must remember to change it back. This problem also limits the types of builders that can be used.

eblen commented 13 years ago

Another problem: Error in advanced settings during wizard (from issue #33): Steps to reproduce:

This occurs because the BuildConfigurationManager is not yet initialized. In fact, none of the sync code has yet been invoked.

eblen commented 13 years ago

Another problem: Select configuration doesn't show workspace configuration (from issue #34):

The workspace/local build configuration is only created at the end of the wizard in org.eclipse.ptp.rdt.sync.ui.wizards.NewRemoteSyncProjectWizard.performFinish(). Because of that it is not shown in "Select configuration" page. This should be fixed. Thus the configuration should be created at the beginning of the wizard not at the end.

CDT has code that deletes configurations that are created too early. This is why creation occurs at the end of the wizard.

rolandschulz commented 13 years ago

On Tue, Jun 7, 2011 at 9:50 AM, eblen < reply@reply.github.com>wrote:

There are multiple problems with the GUI configuration, mainly due to the difficulty of adapting the CDT extensions to work correctly with sync projects. Since these problems and their solutions are likely to be closely related, they are all placed in a single issue. Below are two problems. Others will follow:

1) Initial toolchain selection is ambiguous. Is it for local or remote? For now, it is for both, and the user may have to remember to change one of them later. A toolchain combo on the sync wizard page would help but doesn't eliminate the ambiguity. Is there a better way to present these options to the user?

I think selecting the toolchain on the first and last page would be clear. The first page only asks about local settings (local directory) and the last page only remote (host, directory). Thus if you could select the toolchain on the same page as the location it should be somewhat clear.

2) The sync builder must be used in order for the system to work correctly. Although it is set as the default, users can change it. Even worse, if the user selects an alternate toolchain, the builder is changed to something else. So users must remember to change it back. This problem also limits the types of builders that can be used.

For the workspace/local configuration it should also work to use the default builder, shouldn't it?

Roland

Reply to this email directly or view it on GitHub: https://github.com/rolandschulz/PTP/issues/35

ORNL/UT Center for Molecular Biophysics cmb.ornl.gov 865-241-1537, ORNL PO BOX 2008 MS6309

eblen commented 13 years ago

The following bug is related to this issue:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=356205

eblen commented 13 years ago

Folding issue #42 into this one, as it is another configuration problem:

In the code, we disable the synchronize property page for multi-configurations. If the user selects "all configurations," this works correctly by not allowing modifications. However:

1) If the user selects multi-configurations, no dialog pops up for selecting configurations as on the other pages (Note that you must have three or more configurations before the multi-config option appears.)

2) On multi-configurations, the user can modify the page, but it seems these changes have no effect.

3) We should blank the page rather than just not allowing modifications, which makes the GUI seem broken.

4) Ideally, I suppose, we should allow changes to multi-configurations, although I don't know how much sense that makes for sync.

5) Is there a way to remove the multi-configuration options from the configuration combo when on the sync page?

rolandschulz commented 12 years ago

This issue should be either closed or updated with what is still missing. BTW: What is the status on the CDT change?

eblen commented 12 years ago

The new wizard code is not yet merged into master, so technically all issues still remain. Once it is merged, though, I think only two issues will be left:

1) The sync builder problem

2) The multi-configuration problem

The CDT change is still waiting for review. When Greg returns, I'll ask him to talk to the CDT team.