search

rolandschulz / PTP

Eclipse Parallel Tools Platform
http://www.eclipse.org/ptp/
6 stars 2 forks source link

Handle Obscure File Names and ChannelExec Errors #37

Open eblen opened 13 years ago

eblen commented 13 years ago

For Indigo, we added a fix to handle files with spaces in their names. Files with parentheses or other odd characters still do not work correctly, though. A ChannelExec error usually occurs when the remote "git add" command is attempted. As an interesting test case, the Python 3.2 source fails even after removing the one file with parentheses:

Python_3.2/Misc/TextMate/Python-Dev.tmbundle/Snippets/2 to 3 - Module Deletion (docs).tmSnippet

I was unable to find another file with an odd character, so I don't know the cause of the problem or even if it is a file name issue.

rolandschulz commented 13 years ago

I think this is not a bug in our code but in RemoteTools and should be filed in bugziilla.

On Tue, Jun 7, 2011 at 10:36 AM, eblen < reply@reply.github.com>wrote:

For Indigo, we added a fix to handle files with spaces in their names. Files with parentheses or other odd characters still do not work correctly, though. A ChannelExec error usually occurs when the remote "git add" command is attempted. As an interesting test case, the Python 3.2 source fails even after removing the one file with parentheses:

Python_3.2/Misc/TextMate/Python-Dev.tmbundle/Snippets/2 to 3 - Module Deletion (docs).tmSnippet

I was unable to find another file with an odd character, so I don't know the cause of the problem or even if it is a file name issue.

Reply to this email directly or view it on GitHub: https://github.com/rolandschulz/PTP/issues/37

ORNL/UT Center for Molecular Biophysics cmb.ornl.gov 865-241-1537, ORNL PO BOX 2008 MS6309

eblen commented 13 years ago

This could be seen as a bug in our code. RemoteTools seems to make no attempt to escape characters, so maybe they leave it up to the application to format the command properly. . Also, if we fix it in our code it should work regardless of the builder used.

rolandschulz commented 13 years ago

yes. But I think that RemoteTools should escape because it is modeled after the ProcessBuilder. And if it is fixed in RemoteTools it might help others. I think we should ask Greg/ptp-dev where it should be fixed.

On Tue, Jun 21, 2011 at 11:53 AM, eblen < reply@reply.github.com>wrote:

This could be seen as a bug in our code. RemoteTools seems to make no attempt to escape characters, so maybe they leave it up to the application to format the command properly. . Also, if we fix it in our code it should work regardless of the builder used.

Reply to this email directly or view it on GitHub: https://github.com/rolandschulz/PTP/issues/37#issuecomment-1411352

ORNL/UT Center for Molecular Biophysics cmb.ornl.gov 865-241-1537, ORNL PO BOX 2008 MS6309

eblen commented 12 years ago

A fix for RemoteTools has been submitted, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=354893. It seems that only newline characters are still a problem, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=355270. So I'll leave the bug open but set it to low priority.