search

rolandshoemaker / theca

a simple, fully featured command line note taking tool written in Rust
MIT License
357 stars 18 forks source link

update to recent rust version #7

Closed pwoolcoc closed 8 years ago

pwoolcoc commented 8 years ago

This is a pretty much mechanical translation of the theca code to a recent version of rustc. The version I compiled it with was rustc 1.10.0 (cfcb716cf 2016-07-03), which as of this writing is the most recent stable version of rust. It also compiles with the latest beta and nightly.

As far as I can tell, no logic was changed. All the tests pass, and both lib and bin targets compile without warnings.

Closes #6

cristicbz commented 8 years ago

regex! is slower than just regular runtime Regex-s these days, so maybe this PR should just remove the regex_macros dependency entirely? For global regexes, lazy_static can be used.

pwoolcoc commented 8 years ago

@cristicbz from the looks of it, regex_macros isn't even being used. I can just remove it without making any code changes.

cristicbz commented 8 years ago

I think you could cherrypick the #8 commits if you wanted travis to pass. Though the project looks abandoned. You could create a proper fork of this and I'd use it :)

pwoolcoc commented 8 years ago

@cristicbz yea, I think I will do that

pwoolcoc commented 8 years ago

Seems there is no interest in merging this, so am closing it

cristicbz commented 8 years ago

@pwoolcoc :(

pwoolcoc commented 8 years ago

@cristicbz I have been doing improvements and bug fixes over at https://github.com/pwoolcoc/theca, if you are interested

-------- Original message -------- From: Cristi Cobzarenco notifications@github.com Date: 8/1/16 4:10 PM (GMT-05:00) To: rolandshoemaker/theca theca@noreply.github.com Cc: Paul Woolcock paul@woolcock.us, Mention mention@noreply.github.com Subject: Re: [rolandshoemaker/theca] update to recent rust version (#7)

@pwoolcoc :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.