search

rolandtoth / AdminOnSteroids

Various ProcessWire admin tweaks to boost productivity.
https://processwire.com/talk/topic/13389-adminonsteroids/
GNU General Public License v2.0
39 stars 9 forks source link

CkEditor modal dialogs broken with 4.14.0 #118

Closed adrianbj closed 4 years ago

adrianbj commented 4 years ago

Hey @rolandtoth - since PW upgraded the version of CkEditor to 4.14.0 it's no longer possible to interact with Ckeditor's dialogs, such as View Source, Table, etc.

The culprit is: .cke_dialog_background_cover{z-index:103000 !important} in aos.min.css

There are some other similar rules just after that one which don't seem to be a problem in my limited testing, but maybe they can all be removed or modified so they don't break things?

Thanks!

Sebiworld commented 4 years ago

I had to delete the rule manually from the module's styles/aos.min.css file, because I needed the source-view to work. Until now, there seem to be no negative effects without the rule...

adrianbj commented 4 years ago

because I needed the source-view to work

Remember that this doesn't just affect view source - it also breaks the image insert dialog.

@rolandtoth - I'd submit a PR to fix this, but I honestly don't really understand why any of those cke_* z-index rules are there. Can they all be removed?

rolandtoth commented 4 years ago

@adrianbj

I made those z-indexes that high because I thought that's the best way to make sure the cke overlay covers the admin header, sidebar, etc. So far it was OK, apparently recent ckeditor updates broke this workaround.

I would say if removing the rule you mentioned in the first comment works then it's enough for now, until it proves the opposite :)

rolandtoth commented 4 years ago

Just updated to 2.0.21, please check. I could reproduce the source dialog issue but the image insert dialog was OK here.

tbba commented 4 years ago

I can confirm that its fixed here - thank you!!

adrianbj commented 4 years ago

Yep, all good again now - thanks @rolandtoth