InputfieldCheckbox on AdminThemeUikit has display problems

[gmclelland]

The screenshot shows how the field label doesn't fully span width, so only the label is clickable not the full row.

I think this css rule is causing the issue even when AOS tooltips submodule is disabled:

.aos_hasTooltip .title, .InputfieldCheckbox label {
    position: relative;
    display: inline-block;
}

[gmclelland]

Ok, with the latest update to AdminThemeUikit, the label spans the full width now, but it's missing the borders.

To bring back the borders, I had to do the following:

/* Modified Existing CSS Rule */
html.aos .InputfieldStateCollapsed, html.aos .InputfieldStateWasCollapsed {
    overflow: visible !important;
    position: relative; /*added this*/
}

/* New CSS Rule */
.aos_hasTooltip{
  position:relative;
}

This seems to work on the AdminThemeUikit and the Classic theme.

Hope that helps

[gmclelland]

Hi @rolandtoth - just checking back. I was curious what your plans are for with this module in regards to integrating with AdminThemeUikit module? It looks like some of the issues I posted can be solved in way that works with all the admin themes.

I also forgot to include a screenshot of what it looks like currently without my fixes:

[rolandtoth]

I'm about to fix issues as they come up, just have to find some time to get to them. I've checked some of your mods and they seemed to be ok.

Btw, you can make PR too, that's the quickest way to fix things :) If you're having troubles setting up the preprocess/minify parts, let me know and I'll add a howto on that to the docs.

[gmclelland]

Thanks for the quick reply. I thought about submitting a PR for these changes, but I wasn't sure how you handled compiling the code?

Do you prefer:

• a PR with just CSS/JS changes and no compiled files - so you can compile them in another commit
• a PR with CSS/JS changes and compiled files - this could have merge conflicts

[rolandtoth]

I think it doesn't matter. I usually know that I have made changes to css/js so I can accept the PR entirely with compiled assets if I don't have any unpublished changes. If I have, I will only merge uncompiled assets and recompile.

[gmclelland]

https://github.com/rolandtoth/AdminOnSteroids/pull/65

You'll just need to recompile the .scss for this one.

[gmclelland]

Sorry, I didn't test this well enough. Here is a fix for the latest commit https://github.com/rolandtoth/AdminOnSteroids/pull/69

[gmclelland]

Note: Just so you know, there is also an issue with AdminThemeUikit https://github.com/ryancramerdesign/AdminThemeUikit/issues/49 where Ajax loaded checkbox fields that are side by side don't display correctly.

[gmclelland]

Closing this issue. It is fixed now with https://github.com/rolandtoth/AdminOnSteroids/pull/76