search

rolandtoth / AdminOnSteroids

Various ProcessWire admin tweaks to boost productivity.
https://processwire.com/talk/topic/13389-adminonsteroids/
GNU General Public License v2.0
39 stars 10 forks source link

Margin issue when sticky header is disabled #74

Closed gmclelland closed 7 years ago

gmclelland commented 7 years ago

I noticed when view the Classic default theme and the sticky header is disabled, the page sits to close to the top bar.

modules processwire pwoliver test 2017-10-25 17-11-07

When the sticky header is enabled, everything looks okay.

adrianbj commented 7 years ago

I don't think that is actually the fault of AOS - I think it is the Module Settings Import / Export module, or maybe it's actually a PW core issue when adding a new fieldset before others on the module settings pages. If you disable AOS you'll see it's still a problem.

gmclelland commented 7 years ago

Hmm.. On a different site with an older version of AOS it works properly.

I also tried unistalling the Module Settings Import / Export module, but it made no difference.

If you disable AOS you'll see it's still a problem.

Your right I do see this when the module is disabled.

rolandtoth commented 7 years ago

As I remember there was a fix for this in AOS, perhaps it got removed lately (by accident). I can confirm that it's like this by default.

gmclelland commented 7 years ago

The site that works correctly is using AOS 1.5.7

rolandtoth commented 7 years ago

I guess I was wrong, I thought about the current fix that was present in case sticky header is enabled, so there was no fix for the non-sticky header case. I've fixed it, will update the module soon.

rolandtoth commented 7 years ago

Should be fixed in v163.