rolandtoth / AdminOnSteroids

Various ProcessWire admin tweaks to boost productivity.
https://processwire.com/talk/topic/13389-adminonsteroids/
GNU General Public License v2.0
39 stars 10 forks source link

InputfieldURL and InputfieldAssistedURL display problems #83

Open gmclelland opened 6 years ago

gmclelland commented 6 years ago

Hi @rolandtoth,

I noticed InputfieldURL and InputfieldAssistedURL aren't displaying correctly in adminThemeUikit because of line 3947 of src/aos.scss:

// InputfieldURLChecker
.InputfieldURL,
.InputfieldAssistedURL {
  .InputfieldContent {
    position: relative;
  }
}

For some reason adminThemeUikit doesn't like it when you apply position:relative to .InputfieldContent. It makes the borders disappear. border

Here is what it looks like corrected corrected

So can't we just remove the position: relative and be done with it? Well no unfortunately, the IUC button depends on it for positioning.

I'm really not sure how to fix it in InputfieldURL.

I fixed it in FieldtypeAssistedUrl with this PR https://github.com/marcostoll/processwire-fieldtype-assisted-url/pull/6. I had to add an additional div wrapper to fix the IUC. With that PR I will also need to adjust some css in AOS to get the IUC displaying correctly, but then I ran into this issue where I don't think we can fix it with CSS alone.

I'm curious to hear what you think. Maybe there's a better soluntion I'm just not thinking about.

If we could wrap the InputfieldURL's input with a div and class I think that we could solve it with CSS alone, but I'm not sure if that change would be accepted with a core PW module?

rolandtoth commented 6 years ago

I think I've fixed it, adding position: relative to the parent div. Seems to works fine here on all 3 admin themes, with left or right aligned IUC buttons. I'll upload it later today.

rolandtoth commented 6 years ago

This is available in the latest versions, together with a fix for the vertical positioning of the IUC links.

gmclelland commented 6 years ago

Thanks for working on this. I just tested this, but I didn't see the IUC on my one of my fields. On my homepage I have a repeater that contains an AssistedURL field. I didn't see the IUC on that field so I went to add that field in the AOS module settings, but I wasn't able to add the field.

It seems to only show URL field types, not AsssistedURL field types.