rolandtoth / AdminOnSteroids

Various ProcessWire admin tweaks to boost productivity.
https://processwire.com/talk/topic/13389-adminonsteroids/
GNU General Public License v2.0
39 stars 9 forks source link

Minor Page List Select spacing issue on AdminThemeUikit #92

Closed Toutouwai closed 6 years ago

Toutouwai commented 6 years ago

Occurs when the Page List Select has no page selected.

Without AOS: 2018-05-05_131442

With AOS: 2018-05-05_131430

rolandtoth commented 6 years ago

Thanks, seems like a css clearfix was enough to solve. Will be available in 1.9.3.

Toutouwai commented 6 years ago

Thanks, but the fix in 1.9.3 doesn't seem to be working here. I think the clearfix needs to go on .InputfieldPageListSelect .InputfieldContent.

rolandtoth commented 6 years ago

I cannot seem to reproduce, just tried it on another PW install (latest 101 dev) and with AOS enabled pagelist unselect tweak only (to make sure nothing interferes). Do you have something checked in Uikit field settings by any chance? But if you can confirm the clearfix you mentioned fixes it, I'll add that.

Toutouwai commented 6 years ago

I think I see where the confusion is coming from.

You must be looking at InputfieldPageListSelect when it is used as the inputfield for a Page Reference field, whereas I am looking at cases when InputfieldPageListSelect is used directly, e.g. in a Process module. In these cases the wrapping element is different.

If you apply the clearfix to both of the following it will cover both scenarios: .InputfieldPageListSelect .InputfieldPageListSelect .InputfieldContent

Thanks.

rolandtoth commented 6 years ago

Thanks, just committed this update (no version change).

Toutouwai commented 6 years ago

Thanks.