search

rolandtoth / AdminOnSteroids

Various ProcessWire admin tweaks to boost productivity.
https://processwire.com/talk/topic/13389-adminonsteroids/
GNU General Public License v2.0
39 stars 10 forks source link

1 pixel misalignment of title field in AdminThemeUikit #94

Closed Toutouwai closed 6 years ago

Toutouwai commented 6 years ago

AOS causes a 1 pixel misalignment of the title field in AdminThemeUikit. It becomes noticeable when the width of the title field is not 100% (i.e. it has a neighbouring inputfield on the same row).

2018-05-18_145438

The title field is 1 pixel taller than it should be. And although it's not noticeable in the screenshot above (and hardly matters) it's also 1 pixel wider than it should be.

The issue seems to be related to the position: relative that is added to both the .Inputfield element and the .InputfieldContent element. I think those styles are added to support the case toggle button, but the styles are actually added regardless of whether that option is enabled in AOS.

Not sure of a good solution. Perhaps the case toggle option could also add a containing div around the button and then the button could be positioned relative to that div rather than changing the position property of .Inputfield and .InputfieldContent?

rolandtoth commented 6 years ago

I've removed position: relative (also from the inputfield wrapper) and fixed this with some CSS trickery. Looks OK in all 3 admin themes here.

Toutouwai commented 6 years ago

Thanks.

Looks like position: relative is going to be a headache with inputfields in AdminThemeUikit: https://github.com/processwire/processwire-issues/issues/602#issuecomment-391322517