search

rolandwalker / anaphora

Anaphoric expressions for Emacs Lisp, providing implicit temporary variables.
54 stars 11 forks source link

update to include debugging for all the obvious cases and a version bump #1

Closed nicferrier closed 12 years ago

nicferrier commented 12 years ago

This is great! I've been wanting to do this myself but never got round to it.

The attached patch makes these debuggable. Would you consider pulling it?

Also, maybe consider signing papers and pushing this into emacs proper? If you didn't copy the code directly from onlisp that should be doable.

rolandwalker commented 12 years ago

Thanks for the patch!

Probably about a third is based directly off On Lisp. I have no objection to having this pulled into Emacs -- but in my view I hold no rights over this code, so it is not my decision.

I have marked it public domain. Do you think that was incorrect?

rolandwalker commented 12 years ago

I'm reopening because I broke debug with aliases and had some questions while repairing.

  1. As in 965b6b82fecbbcde5ffebbee8b351a5dd3e2a058, why not refer to the fundamental symbols when they already hold debug properties?
  2. As in 57613a3fcfd20ef40a086cc853bfc9cbb0e36785, why not add debug declarations to a*, et alia? These now seem to behave identically to the corresponding builtins under edebug-eval-defun.
  3. Why use (debug (sexp form &rest form)) for anaphoric if? It doesn't behave identically to if under edebug-eval-defun. The behavior of if seems to be duplicated with (debug t)
nicferrier commented 11 years ago

Hum. I'm not an expert. I was just trying to make it not debug the test but do debug the form.