rolandwalker / fixmee

Quickly navigate to FIXME notices in Emacs
66 stars 4 forks source link

don't set fixmee keybindings like [C-c f], [C-c v] etc. #11

Closed stardiviner closed 8 years ago

stardiviner commented 8 years ago

Those keybindings are usually reserved for user. The better keybinding is [C-c m] prefix. then sub-keybindings. I think [M-g] is better for this case. But don't conflict with Emacs built-in keybindings.

punchagan commented 8 years ago

The key-binding conventions documentation could be helpful.

stardiviner commented 8 years ago

yes, but you can use [M-g] as prefix. And set keybinding not overriding the defualt [M-g] keybinidngs. Because usually will bind [C-c f] etc to prefix. For example I bind [C-c p] for programming projectile prefix.

If you think bind default [M-g] is not good. Then you can leave those keybinding un-bind by default. Or toggle with an option like fixmee-setup-keybindings t.

rolandwalker commented 8 years ago

Hi! Thanks!

This has come up before — I'm aware of the key-binding conventions documentation, but also aware that many libraries do not follow that document. Example: org-mode.

The situation is far from ideal. My feeling is

and that is why I have made the choice of binding under C-c: so things will work easily for a novice.

I'd gladly accept a documentation patch noting this compromise, and describing how to reassign the bindings.

stardiviner commented 8 years ago

I see, thanks. I will disable the minor mode, and setup keybindings manually.

stardiviner commented 7 years ago

I realized this really need an customize variable defcustom to let user can custom fixmee keybindings.

stardiviner commented 7 years ago

I have an alternative option, provide an option decustom fixmee-setup-keybindings, so that user can decide whether auto setup keybindings when load global-fixmee-mode or fixmee-mode. This option can be t by default. But some user like me can set it to nil to disable it when mode loaded. What do you think? I can't find alternative better similar extension like fixmee. But this keybinding issue is really annoying that fixmee override my custom keybinding when load fixmee-mode.