search

rolaveric / karma-systemjs

Karma plugin for using SystemJS as a module loader
MIT License
40 stars 19 forks source link

useBundles setting ignored #91

Open ghost opened 7 years ago

ghost commented 7 years ago

I was digging around trying to work around #90, so I tried to use the useBundles setting and noticed it seems to have no effect.

I put a breakpoint at https://github.com/rolaveric/karma-systemjs/blob/22c0f98ba25ca385729e46f249ff35670ab43c1a/lib/adapter.js#L164 and saw that the useBundles property was not set.

It seems that only the properties set at https://github.com/rolaveric/karma-systemjs/blob/651750b5897f1fadebaaea4a9e34a4b9b5a6bbab/lib/framework.js#L263 are persisted.

So this if block checks for the existence of a property that will never exist, and therefore runs unconditionally - and throws an error in SystemJS 0.20.

AdamWillden commented 7 years ago

@errorx666 thanks for pointing this out. It helped me create #92