fix: useBundles option is not respected and was set incorrectly for systemjs

[AdamWillden]

The method for setting bundles changed May 2015 here (tagged systemjs@0.17): https://github.com/systemjs/systemjs/commit/2141c64b31f2b4b35f9089c2f306049d334c652e

Closes #91, #90

[AdamWillden]

I assume you're not targeting systemjs @ < 0.17

[AdamWillden]

I should say I have no way of running the plugin to properly test it... as I'm using another plugin which depends upon this. I assume you know of way to test this yourself @rolaveric?

[jcestibariz]

This fix works for me with: karma@1.4.1 systemjs@0.20.5

[AdamWillden]

Thanks @jcestibariz :-)

I've since realised that multiple calls to System.config are okay so the code could be simplified a bit so that rather than modifying karma.config.systemjs.config we could just call System.config({ bundles: [] }); afterwards.

[jcestibariz]

@AdamWillden: Sounds good, if you make the changes I can test again.

[jcestibariz]

@AdamWillden, @jamesbrobb actually looks like #85 (which was included in r0.16.0) is causing both this problem and #86.

I also went back to r0.15.0 and I don't see this problem anymore.

I think the fix for both is to rollback that change. The solution for the problem in #85 is just to specify an empty bundles array in the karma.systemjs configuration to override the bundles in the systemjs configuration.

[kuakman]

Any update on when this fix will be merged and released? Looks like this bug is causing SystemJs to break with versions 0.17 and above.

[klemenoslaj]

Any update so far? Pull request still pending since February 6th

[timfish]

@rolaveric was looking for somebody to take over maintenance

[Izzmo]

Is @rolaveric MIA at this point?

[AdamWillden]

Closing so it's not appearing in my PR list https://github.com/pulls

Clearly dead and I haven't used it in years