Ftppush - Fix issue #139 and prepare configurable ftp port

roleoroleo / sonoff-hack

Custom firmware for Sonoff GK-200MP2B camera

GNU General Public License v3.0

200 stars 45 forks source link

Closed couriersud closed 1 year ago

couriersud commented 1 year ago

add sonoff-hack/usr/bin/rmdir to enable rmdir
above fixes issue #139
@darkxt proposed more code changes (see #139). This PR follows a minimum changea approach an fixes the missing rmdir
The PR allows replaces the hardcoded port 21 for FTP with a variable called FTP_PORT
This may be extended using get_config to provide a ftp port configured in the UI

couriersud commented 1 year ago

The PR should now be complete. Port is also configurable in the UI.

couriersud commented 1 year ago

Sorry, the next window to work on this is in a couple of weeks. I have already invested a lot more time than anticipated into this.

number of commits -> commits can be squashed when the PR is applied. You will see another proof-of-concept PR to document a possible solution for immediate motion feedback by mqtt on S-CAM devices.

darkxst commented 1 year ago

They are only very minor edits, just use git rebase to apply the edits to the commits and force push your branch again ;)

couriersud commented 1 year ago

I have applied your comments.

roleoroleo commented 1 year ago

Thank you for this PR.