search

rolfberkenbosch / meteoalert-api

MIT License
12 stars 10 forks source link

Meteoalert hangs endlessly if meteoalarm.eu doesn't respond #14

Closed pskowronek closed 3 years ago

pskowronek commented 3 years ago

Meteoalert hangs endlessly if meteoalarm.eu doesn't respond - this happened today, their site was not responding on time and meteoalarm lib hang (my whole clock suddenly stopped :)). There should be a reasonable timeout implemented while making a request to their server.

Now the site works so cannot provide steps to reproduce, probably the URL has to be change to something behind firewall silently blocking traffic.

This occurred on version 0.1.6, I guess I don't see any relevant changes in 0.1.7, so I think this issue still exists.

rolfberkenbosch commented 3 years ago

Sorry for my late response. Meteoalarm has finally update their api and moved to another domain. I hope it will be more responsive. For details check: https://github.com/home-assistant/core/pull/51383

pskowronek commented 3 years ago

The stability of their new API and/or domain/hosting is irrelevant, the main problem is still there - if something goes wrong on connection level, the library may hang endlessly. So, I wouldn't close this issue :)