search

rolfvreijdenberger / izzum-statemachine

A superior finite state machine library for php >= 5.3 including php 7
MIT License
64 stars 13 forks source link

bugfix #6

Closed manuelbcd closed 8 years ago

manuelbcd commented 8 years ago
manuelbcd commented 8 years ago

I have reassessed changes and they are not necessary

rolfvreijdenberger commented 8 years ago

Hi @manuelbcd , thank you for your time and contribution.

Some feedback on the line "$statement->bindParam(":machine", $identifier->getMachine());" that line will make the PDO library complain, since for some reason the second parameter of the bindParam method should not be an expression/evaluation.

Are you using the library and what is your experience with it?

manuelbcd commented 8 years ago

Hey! Thanks for contacting me. This Pull request was mistaken. Apologise for the inconvenience. my experience is good with statemachine and redis but Im facing some problems when I use mysql pdo.

Wbr

Manuel Boira El 19/4/2016 22:00, "Rolf Vreijdenberger" notifications@github.com escribió:

Hi @manuelbcd https://github.com/manuelbcd , thank you for your time and contribution.

Some feedback on the line "$statement->bindParam(":machine", $identifier->getMachine());" that line will make the PDO library complain, since for some reason the second parameter of the bindParam method should not be an expression/evaluation.

Are you using the library and what is your experience with it?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/rolfvreijdenberger/izzum-statemachine/pull/6#issuecomment-212102562