rolinh / dfc

Report file system space usage information with style
BSD 3-Clause "New" or "Revised" License
106 stars 10 forks source link

Dutch translation #3

Closed MichielPater closed 8 years ago

MichielPater commented 8 years ago

Dear Robin,

In this version I first added the Dutch language :). Wow, that was a bit more work than expected, but it is there!

However, I did not manage to get it working on my Debian Linux yet. I'm not sure if my language settings are correct.

Please have a look at it.

With kind regards,

Michiel

MichielPater commented 8 years ago

When I changed my system language to French, I also couldn't get it to work. Am I doing something wrong? I am using Debian by the way. My system displays French, but dfc doesn't.

rolinh commented 8 years ago

Hi Michiel,

Thanks for your contribution. Your changes seem fine. You only miss one thing: generating your locale :) You need to add nl to po/LINGUAS and then you are good to go:

diff --git a/po/LINGUAS b/po/LINGUAS
index 527e861..3637db6 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -1 +1 @@
-fr
+fr nl

It works here (yup, I did not copy the dutch configuration file):

$ LANG=nl_NL.utf8 ./build/bin/dfc
Onbekende kleurwaarde: blue
Onbekende kleurwaarde: green
Onbekende kleurwaarde: yellow
Onbekende kleurwaarde: red
Fout bij het lezen van het configuratiebestand: /home/robin/.config/dfc/dfcrc
BEST.SYSTEEM (=) GEBR      GEBR (-)  %GEBR BESCHIKB.   TOT. MOUNT          
dev          [--------------------]   0,0%      3,8G   3,8G /dev           
run          [=-------------------]   0,0%      3,8G   3,8G /run           
/dev/sda1    [===================-]  92,0%     18,1G 226,7G /              
tmpfs        [=-------------------]   1,7%      3,7G   3,8G /dev/shm       
tmpfs        [--------------------]   0,0%      3,8G   3,8G /sys/fs/cgroup 
tmpfs        [=-------------------]   0,0%      6,0G   6,0G /tmp           
tmpfs        [=-------------------]   0,0%    776,5M 776,5M /run/user/1000 

I notice that the dutch locale uses "," as the decimal separator. This might be a problem for the CSV export. Well, I think that CSV export need to be locale aware. I should open a bug for that. In the meantime, I suggest to change the default CSV separator for dutch via the configuration file.

MichielPater commented 8 years ago

Dear Robin,

I updated your requests. However, it is sadly still not working for me. This is my language info:

$ locale
LANG=nl_NL.UTF-8
LANGUAGE=
LC_CTYPE="nl_NL.UTF-8"
LC_NUMERIC="nl_NL.UTF-8"
LC_TIME="nl_NL.UTF-8"
LC_COLLATE="nl_NL.UTF-8"
LC_MONETARY="nl_NL.UTF-8"
LC_MESSAGES="nl_NL.UTF-8"
LC_PAPER="nl_NL.UTF-8"
LC_NAME="nl_NL.UTF-8"
LC_ADDRESS="nl_NL.UTF-8"
LC_TELEPHONE="nl_NL.UTF-8"
LC_MEASUREMENT="nl_NL.UTF-8"
LC_IDENTIFICATION="nl_NL.UTF-8"
LC_ALL=

I tried the following commands:

$ LANG=nl_NL.utf8 ./dfc
$ LANG=nl_NL.UTF-8 ./dfc

The same happens for French. Do you have any suggestions?

rolinh commented 8 years ago

Yes, it cannot find the translation file most probably. Try installing with make install (don't worry, there is a make uninstall target as well).

MichielPater commented 8 years ago

It is working perfectly now and ready to commit, thank you!

rolinh commented 8 years ago

Thanks for your contribution!