rolinh / dfc

Report file system space usage information with style
BSD 3-Clause "New" or "Revised" License
106 stars 10 forks source link

-M option #5

Closed MichielPater closed 8 years ago

MichielPater commented 8 years ago

-M: do not print "mounted on"

rolinh commented 8 years ago

Hi Michiel,

I think that you mean

static void text_disp_ln_end(void);
/* ... */
static void
text_disp_ln_end(void)
{
        (void)printf("\n");
}

Instead of

static void text_disp_ln_end();
/* ... */
static void
text_disp_ln_end()
{
        (void)printf("\n");
}

And so on for every _disp_ln_end() export function. (C != C++ :wink: )

LGTM otherwise.

MichielPater commented 8 years ago

Updated, tested and works.

rolinh commented 8 years ago

I have a suggestion though: I think it makes sense to take into account this new "-M" option for the auto-adjust feature (see auto_adjust() in src/util.c), probably around the Tflag check.

MichielPater commented 8 years ago

Should be better now. There was supposed to be a \n

rolinh commented 8 years ago

I think you mean to update update_maxwidth() for -M flag support instead of adding your checks with 0f5f77f44b61bd03887d6fa6219d354b22a01544.

MichielPater commented 8 years ago

Updated.

rolinh commented 8 years ago

Thanks!