rollbar / Rollbar.NET

Rollbar for .NET
https://docs.rollbar.com/docs/dotnet
MIT License
65 stars 44 forks source link

No option to set code_version at the config level in v5 of the SDK #630

Closed tattan closed 2 years ago

tattan commented 2 years ago

Is your feature request related to a problem? Please describe. In v4 of the SDK this issue was created https://github.com/rollbar/Rollbar.NET/issues/13 and fixed. I was looking for a way to do that or something similar in v5 of the SDK

Describe the solution you'd like I'd like to be able to include code_version (not server code_version) at either the RollbarInfrastructureConfig or RollbarLoggerConfig.

Describe alternatives you've considered Having a custom wrapper that takes a Body and sets the version for each rollbar item to be sent.

akornich commented 2 years ago

@tattan , actually it looks like #13 and #14 happened during v0 of the SDK. Let me see what we can do here...

akornich commented 2 years ago

@tattan , for now, you can probably define your own payload transform action here so you can assign the desired code version to every processed payload...

akornich commented 2 years ago

@tattan , now as a long-term solution, what if I add new nullable CodeVersion property here and will be assigning to every payload's Data.CodeVersion if defined (not null)?

tattan commented 2 years ago

@akornich I think your long-term solution would be great. I'll implement a transform in the meantime. Thank you

DrewSaucier commented 2 years ago

@akornich do you have a timeline on this request. We are bumping up against as well in v4 to v5 updating.

Thank you!

akornich commented 2 years ago

@DrewSaucier , I'll try to have it out sometime this week.

akornich commented 2 years ago

now available in v5.2.0...

tattan commented 2 years ago

Hi @akornich, the proposed solution was implemented to spec but did not have the same effect as setting code_version in the root of the json body.

Setting notifier.infrastructure_options.RollbarloggerConfig.RollbarPayloadAdditionOptions.CodeVersion and notifier.configured_options.RollbarPayloadAdditionOptions.CodeVersion does not update the github (in our case) link displayed in the code_version column.

For now we are continuing to use a transform to achieve the desired result but I wanted to know if your intent was to have the sha sum set correctly and the link to source control generated when a given occurrence is sent as it is if you send a sha value for code_version in the root of the payload.

DrewSaucier commented 1 year ago

Thank you!

Drew Saucier Vice President Paul Consulting Group Direct 850-610-6964 Cell 850-251-1389

From: Andrey Kornich (Wide Spectrum Computing LLC) @.> Sent: Tuesday, May 17, 2022 2:06 AM To: rollbar/Rollbar.NET @.> Cc: Drew Saucier @.>; Mention @.> Subject: Re: [rollbar/Rollbar.NET] No option to set code_version at the config level in v5 of the SDK (Issue #630)

now available in v5.2.0...

- Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frollbar%2FRollbar.NET%2Fissues%2F630%23issuecomment-1128448672&data=05%7C01%7Cdrew%40paulconsulting.com%7Ceac5615eb29745c1820308da37cb544a%7C6299f030b5ff495481a867a7055284e5%7C0%7C0%7C637883643707177958%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EFjLqiTEquo1krGUopKN0ppxYIxGnaCOSOsgdX9peVo%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZBVLJ7UTRDOPWA7IKGY22TVKMZM3ANCNFSM5TEIAURA&data=05%7C01%7Cdrew%40paulconsulting.com%7Ceac5615eb29745c1820308da37cb544a%7C6299f030b5ff495481a867a7055284e5%7C0%7C0%7C637883643707177958%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6bX9ugEsZPAzau8Mujppy97nOOPhvkLz8nYzDa5d4tE%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>