Search for config loader assembly in bin subfolder - Githubissues

rollbar / Rollbar.NET

Rollbar for .NET

https://docs.rollbar.com/docs/dotnet

MIT License

65 stars 44 forks source link

Search for config loader assembly in bin subfolder #640

Open jacob-ewald opened 1 year ago

jacob-ewald commented 1 year ago

Description of the change

In some .Net projects the assemblies are output to the "bin" subfolder, and the execution context is in the parent folder. This change checks for the existence of the "bin" folder and uses that when present.

Type of change

[X] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance
[ ] New release

Related issues

Fix #636

Checklists

Development

[X] Lint rules pass locally
[X] The code changed/added as part of this pull request has been covered with tests
[X] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

jacob-ewald commented 1 year ago

There are 3 failed tests, but they are not related to the change I made. Any guidance on how to handle those?