added verify_https for twisted - Githubissues

rollbar / pyrollbar

Error tracking and logging from Python to Rollbar

https://docs.rollbar.com/docs/python/

MIT License

213 stars 135 forks source link

added verify_https for twisted #366

Closed pawelsz-rb closed 3 years ago

pawelsz-rb commented 3 years ago

Description of the change

added verify_https for twisted

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#1]()

Checklists

Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[x] Issue from task tracker has a link to this pull request

pawelsz-rb commented 3 years ago

👍

just to confirm, with this, we can now use the twisted handler to send items with verify_https=False, correct?

correct