rollbar / pyrollbar

Error tracking and logging from Python to Rollbar
https://docs.rollbar.com/docs/python/
MIT License
213 stars 133 forks source link

Pinned Python 2 CI tests to legacy version of dependencies #408

Closed danielmorell closed 2 years ago

danielmorell commented 2 years ago

Description of the change

certifi is a package that helps validate SSL root certificates that we depend on. In the latest release it started using Python 3 syntax. Since we have always been using the latest version, our Python 2 CI tests started failing after the last release of certifi.

This PR pip installs certifi==2021.10.8 if our CI test matrix is testing on Python 2.7. This is not an ideal solution seeing that we will not be using up to date root certificates in our tests. However, that may be a compromise we are willing to make.

Type of change

Related issues

None (see our latest failed action run)

Checklists

Development

Code review

danielmorell commented 2 years ago

Yeah. Not having up to date SSL root certs is kind of a big deal. I haven't thought of any great way to solve that.